tylerschroeder7 / MI-449-SS17-740-html-atom-and-basic-elements-JmL5o8

0 stars 0 forks source link

Project Feedback #1

Open tylerschroeder7 opened 7 years ago

tylerschroeder7 commented 7 years ago

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

KatieMFritz commented 7 years ago

LOL at Han Solo's resume (seriously, you probably just heard me chuckling in the corner).

Use headings in order

Headings (h1, h2, etc.) are used not just to convey information visually to the reader, but also to give information about the structure of the page. We use them to create an outline.

In your project, you have some h4s for some sections and h2s for other sections. When I read the resume, it seems like all of those sections should be on the same level of the document's outline - so they should all be h2. h4 would be a subheading underneath h3, which would be a subheading under h2.

Every rule can be broken, so feel free to make an argument if you're familiar with semantic HTML and you did this on purpose. 😄 Otherwise, please change all your subheadings to h2.

Make image clickable

At least one external image is used and links to the page it came from

By this, we mean that the image itself should be the link to the page the image came from. It may have been a little ambiguous - sorry! Check out "Making images clickable" on page 6 of the lesson if you're not quite sure what I mean.

Let me know when the project is updated and I'll look it over again! 😸

tylerschroeder7 commented 7 years ago

Hey Katie,

Sorry about the confusion! I went through and made the changes. I am familiar with the header hierarchy 1-6 but i changed them all to h2 for the assignment. The picture is also linked to the source now.

-Tyler


From: Katie Fritz notifications@github.com Sent: Tuesday, January 17, 2017 4:46:59 PM To: tylerschroeder7/MI-449-SS17-740-html-atom-and-basic-elements-JmL5o8 Cc: Schroeder, Tyler James; Author Subject: Re: [tylerschroeder7/MI-449-SS17-740-html-atom-and-basic-elements-JmL5o8] Project Feedback (#1)

LOL (seriously, you probably just heard me chuckling in the corner).

Use headings in order

Headings (h1, h2, etc.) are used not just to convey information visually to the reader, but also to give information about the structure of the page. We use them to create an outline.

In your project, you have some h4s for some sections and h2s for other sections. When I read the resume, it seems like all of those sections should be on the same level of the document's outline - so they should all be h2. h4 would be a subheading underneath h3, which would be a subheading under h2.

Every rule can be broken, so feel free to make an argument if you're familiar with semantic HTML and you did this on purpose. ? Otherwise, please change all your subheadings to h2.

Make image clickable

At least one external image is used and links to the page it came from

By this, we mean that the image itself should be the link to the page the image came from. It may have been a little ambiguous - sorry! Check out "Making images clickable" on page 6 of the lessonhttps://msu.lansing.codes/courses/MI-449-SS17-740/lessons/html-atom-and-basic-elements/6 if you're not quite sure what I mean.

Let me know when the project is updated and I'll look it over again! ?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tylerschroeder7/MI-449-SS17-740-html-atom-and-basic-elements-JmL5o8/issues/1#issuecomment-273310369, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVBNf-GPsG6QgyiGsoCPJM-eFwXh7Thqks5rTTbTgaJpZM4LmMJX.

KatieMFritz commented 7 years ago

Great job! Thanks for untangling that Github Issue problem too. 😎

:shipit: