tylerturdenpants / ember-attacher

Native tooltips and popovers for Ember.js
https://tylerturdenpants.github.io/ember-attacher/
MIT License
82 stars 44 forks source link

Dependency lint finds multiple version of ember-compatibility-helpers #127

Closed kriswill closed 6 years ago

kriswill commented 6 years ago

When running ember test on my app, it complains about ember-compatibility-helpers consumed from deep within ember-attacher.

not ok 1 Chrome 65.0 - DependencyLint ember-compatibility-helpers
---
message: >
  Expected only one version of ember-compatibility-helpers, but found
  @org/app
  └─┬ @org/v0-engine
    └─┬ @org/presentation
      └─┬ ember-attacher
        └─┬ ember-popper
          ├── ember-compatibility-helpers@0.1.3
          ├─┬ @ember-decorators/argument
          │ └── ember-compatibility-helpers@1.0.0-beta.2
          └─┬ ember-decorators
            ├─┬ @ember-decorators/component
            │ └─┬ @ember-decorators/utils
            │   └── ember-compatibility-helpers@1.0.0-beta.1
            ├─┬ @ember-decorators/controller
            │ └─┬ @ember-decorators/utils
            │   └── ember-compatibility-helpers@1.0.0-beta.1
            ├─┬ @ember-decorators/data
            │ └─┬ @ember-decorators/utils
            │   └── ember-compatibility-helpers@1.0.0-beta.1
            ├─┬ @ember-decorators/object
            │ ├── ember-compatibility-helpers@0.1.3
            │ └─┬ @ember-decorators/utils
            │   └── ember-compatibility-helpers@1.0.0-beta.1
            └─┬ @ember-decorators/service
              └─┬ @ember-decorators/utils
                └── ember-compatibility-helpers@1.0.0-beta.1
kriswill commented 6 years ago

using:

// config/dependency-lint.js
module.exports = {
  allowedVersions: {
    // ember-attacher is using various versions
    'ember-compatibility-helpers': '*'
  }
};

temporary work-around for dependency-lint, by suspending the constraints for this add-on.

kybishop commented 6 years ago

Thanks @kriswill! Will see about adding a version bump downstream

kybishop commented 6 years ago

Closed via #152