search

tylerturdenpants / ember-attacher

Native tooltips and popovers for Ember.js
https://tylerturdenpants.github.io/ember-attacher/
MIT License
82 stars 44 forks source link

Error in ember 3.28.x wrong import of htmlSafe, isHTMLSafe #661

Closed pabloascarza closed 1 year ago

pabloascarza commented 2 years ago

Hi, threres an error in this line

https://github.com/kybishop/ember-attacher/blob/2b072e1b7cab46b503bfbcb6a3f383ec68198783/addon/components/attach-popover.js#L11

you are importing

import { htmlSafe, isHTMLSafe } from '@ember/string';

but @ember/string dosen't have those methods the correct import is

import { htmlSafe, isHTMLSafe } from '@ember/template';

The wierd thing is how this errors aren't getting on other version of ember because ember/string never got the htmlSafe, isHTMLSafe methods on the older versions. There's a fix here https://github.com/kybishop/ember-attacher/pull/583 can you merge this?

pzubar commented 1 year ago

Requested changes were made in the migration to Floating UI PR (and should be released soon).