Closed hoylemd closed 3 months ago
Instead of a twiddle, can you push a minimal reproduction to a repo? Please create a new app with the ember version you are using, your current dependencies, and an example of the bug.
Thank you
Hey @tylerturdenpants! I have identified the issue and recommend promptly reverting the https://github.com/tylerturdenpants/ember-attacher/pull/932. It seems that dropping @ember/render-modifiers
is a bit more challenging in our case.
Could you please review the PR and help me release the patch version? I don't have sufficient rights to push to master branch, so I can only release to npm and not to GitHub. Thank you!
@pzubar I will still review the PR but maybe we should fix your access to the master branch?
Do you still want a demo repo? I might be able to make some time for that tomorrow, but if you've already got the problem dialed in I don't want to waste my time :p
@hoylemd, please test the 3.1.1
version to confirm the problem has been resolved
@tylerturdenpants, yes I would appreciate gaining access to the master branch for making official releases
@pzubar I will work on your access today. @krasnoukhov do you need any acess modifications?
@hoylemd, please test the
3.1.1
version to confirm the problem has been resolved
That fixed it! thank you! I'll close this then
@tylerturdenpants I can merge but I don't have the force merge rights
When using the LazyRender option, the first time a tooltip appears, it doesn't go away when I move my mouse away from the triggering element. If I mouse over it again, it hides properly, but that first render is quite sticky.
e.g. template:
And quick screencap:
https://github.com/tylerturdenpants/ember-attacher/assets/569403/537a3bd4-de2d-49cd-bdfc-060b04e761cf
Works fine if I remove @lazyRender:
https://github.com/tylerturdenpants/ember-attacher/assets/569403/62162116-5394-4000-aa43-3ba993847c9f
First appeared after upgrading from v2.0.8 to v3.1.0
Running in an ember-cli v3.28.5 app
Re issue template instructions:
I tried to make an ember-twiddle to reproduce the bug, but I couldn't get even a basic one to work with an updated version of ember-attacher. I think ember-twiddle only supports up to ember 3.18, and
ember-attacher
requires at least 3.20, so it just never finishes building dependencies :/I also wasn't able to reproduce it with the example site. I'm not sure if that's because the component is initially created with
lazyRender
off on that page, and it gets modified after page load, or if it's a problem with my app (I've only tested it within my app - didn't really have time to spin up a new one just to test this).