tylerwalts / puppet-jdk_oracle

Puppet module to install JDK from oracle using wget
Other
15 stars 54 forks source link

revert default values of $default_java and $create_symlink back to true #72

Closed fraenki closed 7 years ago

fraenki commented 7 years ago

With PR #69 the default value of $default_java and $create_symlink was silently changed from true to false. IMHO the old value of true makes total sense, as many people will want to use the downloaded Java as the new default.

There was no explanation provided for the change, so I consider it to be a mistake and suggest to revert back to the old default. This PR restores the old behaviour and updates the README accordingly.

tylerwalts commented 7 years ago

Thank you, agreed.