search

tylerwalts / puppet-jdk_oracle

Puppet module to install JDK from oracle using wget
Other
15 stars 54 forks source link

Added hash parameter #75

Closed ffquintella closed 7 years ago

ffquintella commented 7 years ago

A new parameter is needed to download files from oracle

tylerwalts commented 7 years ago

Thanks for the update. Are there some same defaults that can be put in for the hash? Ideally we could still use the module by just including it and use the default params.

Is the hash unique per download, and would one find this easily? It doesn't look obvious from the download pages, without going through the whole manual download process in advance: http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html

ffquintella commented 7 years ago

I don't think so ... since oracle probably will use one to each version it would be confusing. What you can do is select a version as de default one and select this as de default value

dploeger commented 7 years ago

@ffquintella Would you mind replacing the double quoted strings with single quoted strings? I guess, that's all, that's blocking Travis. (see https://travis-ci.org/tylerwalts/puppet-jdk_oracle/jobs/195567506#L304)