search

tymondesigns / angular-locker

🗄️ A simple & configurable abstraction for local/session storage in angular js projects
https://npm.im/angular-locker
MIT License
314 stars 42 forks source link

Fix driver support checking for custom drivers #18

Closed zachjs closed 9 years ago

zachjs commented 9 years ago

If localStorage is not available, Locker does not work properly with other drivers. When Locker's functions call _checkSupport() (without any parameters), it checks if the browser supports localStorage specifically, even if that instance is using some other driver. This only really causes an issue if localStorage is not available, when using some other driver as a fallback is most critical.

Please let me know what your thoughts are.

tymondesigns commented 9 years ago

Yea this makes sense, thanks!