tymondesigns / angular-locker

🗄️ A simple & configurable abstraction for local/session storage in angular js projects
https://npm.im/angular-locker
MIT License
314 stars 42 forks source link

Problem when trying to put or access multiple 'session' object. #22

Closed SteveFidel closed 9 years ago

SteveFidel commented 9 years ago

Hi,

I've got a weird issue while trying to set multiple session values using the latest release (2.0.1). My default driver option is 'local'.

So if I do the following:

locker.driver('session').put('sessionKey1', 1); locker.driver('session').put('sessionKey2', 2); locker.driver('local').put('localKey1', 1); locker.driver('local').put('localKey2', 2);

"sessionKey1" is set as a SessionStorage, but all three others are set as LocalStorage. The problem here is that "sessionKey2" should have been a SessionStorage not LocalStorage.

But if I change the order like this:

locker.driver('session').put('sessionKey1', 1); locker.driver('local').put('localKey1', 1); locker.driver('session').put('sessionKey2', 2); locker.driver('local').put('localKey2', 2);

Everything work as expected.

tymondesigns commented 9 years ago

Yea, I have just reproduced this. it was caused by this line - https://github.com/tymondesigns/angular-locker/blob/master/src/angular-locker.js#L632

Will release a patch release for this shortly

SteveFidel commented 9 years ago

Great, thanks for your quick replies.... really appreciated :)

tymondesigns commented 9 years ago

done :) 2.0.2 should be available