Closed MatanYadaev closed 4 years ago
Pretty please
We could really use support for Laravel v6 as well.
is this project alive?
@shirshak55 I think you'll find it more updated than most others, just have patience :) Laravel 6 isn't even out yet.
Laravel 6 is out ;)
Waiting for L6 support!
Waiting for L6 Support.
Currently on vacation guys. I will get it updated as soon as I can
Waiting for L6 Support.
Waiting for L6 Support++
@tymondesigns is this project still in active development or are you just in keep it alive
mode?
@joelwmale In my opinion, this project is not in active development, it is very popular and has very nice test coverage, but it's definitely not in active development, the project is on release candidate for 2 years, 4 years with the alpha versions, and version 1.0 didn't release yet.
Docs aren't fully, releases seem to be only for bumping Laravel's version, tests fail on develop
branch...
I think we can use Laravel Passport :)
@shirshak55 Laravel Passport and JWT Auth are not the same thing :).
If people urgently need Laravel 6 support, remember you can use @MatanYadaev's fork.
"repositories": [
{
"type": "vcs",
"url": "https://github.com/MatanYadaev/jwt-auth"
}
],
"require": {
"tymon/jwt-auth": "dev-feature/laravel-6-support#0be3f2811dee67b63c756ca44d2a1eea0a910982"
}
@tymondesigns - enjoy your holiday!
@MatanYadaev thanks for your fork. But this is not a permanent solution. Is there any good alternative for this package? I used this in all my projects but didn't notice any active developments since the last couple of years. I am stuck just because of this package & looks like its better to move to some alternatives.
The maintainer wrote that he is on vacation, so please be patient. As a temporary solution I forked the project and updated the composer.json file. Once this project is updated I can easily switch back.
There's an easier temporary solution btw, not requiring someones fork. I'm not saying to advocate this, but maybe you want to upfront test this package, so here:
"repositories": [
{
"type": "package",
"package": {
"name": "tymon/jwt-auth",
"type": "library",
"version": "1.0.0-rc.4.2",
"dist": {
"url": "https://github.com/tymondesigns/jwt-auth/archive/1.0.0-rc.4.1.zip",
"type": "zip"
},
"require": {
"illuminate/auth": "^6.0",
"illuminate/contracts": "^6.0",
"illuminate/http": "^6.0",
"illuminate/support": "^6.0",
"lcobucci/jwt": "^3.2",
"namshi/jose": "^7.0",
"nesbot/carbon": "^1.0 || ^2.0"
},
"autoload": {
"classmap": [
"src/"
]
}
}
}
]
--- "tymon/jwt-auth": "1.0.0-rc.4.1"
+++ "tymon/jwt-auth": "1.0.0-rc.4.2"
As said, this is just a temporary thing but you don't need a fork for this.
@mfn thanks for this solution, it worked and I was able to upgrade to Laravel 6. After the upgrade, the connexions of registered users are rejected as unauthorized. Do you think it's related to the rc4.2 or to Laravel 6?
@Kamalito75 it's not going to be Laravel 6's fault. It is because the package needs to be updated properly. The updates people are posting here are not the true solutions.
@joelwmale thanks for your advice. I'll wait for the proper update then.
It's just temporary, yes; if it's not working, everyone has to wait. And everyone deserves to be on vacation 😄
Interestingly, my use case of this package worked but I'm only using a very limited subset of it.
So does mine. It also depends which version of PHP you are running. There is an issue with 7.3, but 7.2 seems to work.
waiting for L6 support.
I'm confirm that @MatanYadaev's fork is worked on Laravel 6 with PHP 7.3, maybe update your PR https://github.com/tymondesigns/jwt-auth/pull/1861 ?
@Kamalito75
After the upgrade, the connexions of registered users are rejected as unauthorized. Do you think it's related to the rc4.2 or to Laravel 6?
I had similar problem but it turned out Laravel was not auto discovering the service provider. Adding Tymon\JWTAuth\Providers\LaravelServiceProvider::class
to the config/app.php
file solved my issue.
Every morning to see if there is any adaptation laravel6.0
🙃
I have made the necessary changes on the develop branch which can be tested via 1.0.x-dev
for the time being. I want to do some real testing with Laravel 6 for myself to make sure everything is good and then I will tag a release.
Let me know if anyone has any issues with latest on develop
@tymondesigns i'm have tested 1.0.x-dev
on my package https://github.com/cleancode-id/laravel6-api-boilerplate, it works with Laravel 6.
PHP 7.3.9 (cli) (built: Aug 30 2019 01:42:25) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.9, Copyright (c) 1998-2018 Zend Technologies
with Xdebug v2.7.2, Copyright (c) 2002-2019, by Derick Rethans
with Zend OPcache v7.3.9, Copyright (c) 1999-2018, by Zend Technologies
"require": {
"php": "^7.2",
"fideloper/proxy": "^4.0",
"laravel/framework": "^6.0",
"laravel/tinker": "^1.0",
"tymon/jwt-auth": "1.0.x-dev"
}
Great, thank you! 🚀
@tymondesigns It's not related to the issue, but I am interested to know if there are plans to publish v1 of this package? Any roadmap? Open tasks?
@yohang88 great 👍
@MatanYadaev Yes I plan on dedicating some real time to cleaning up everything now. I have some unpushed documentation that I have been working on recently that will include a proper upgrade guide from 0.5.x too.
I have created a github project that I will be adding issues to over the coming days, then it's clear what is left to do.
@tymondesigns i'm have tested
1.0.x-dev
on my package https://github.com/cleancode-id/laravel6-api-boilerplate, it works with Laravel 6.PHP 7.3.9 (cli) (built: Aug 30 2019 01:42:25) ( NTS ) Copyright (c) 1997-2018 The PHP Group Zend Engine v3.3.9, Copyright (c) 1998-2018 Zend Technologies with Xdebug v2.7.2, Copyright (c) 2002-2019, by Derick Rethans with Zend OPcache v7.3.9, Copyright (c) 1999-2018, by Zend Technologies
"require": { "php": "^7.2", "fideloper/proxy": "^4.0", "laravel/framework": "^6.0", "laravel/tinker": "^1.0", "tymon/jwt-auth": "1.0.x-dev" }
Great, it's works, thank you! 🚀
Version now tagged
@tymondesigns looks like the todo is empty.. is it ready? 👼
I used simple https://github.com/firebase/php-jwt with laravel 6.0, it's not so hard to implement it :)
guys , i was struggling with this error : " symfony\component\debug\exception\fatalthrowableerror: argument 1 passed to tymon\jwtauth\blacklist::__construct() must be an instance of tymon\jwtauth\contracts\providers\storage, null given, called in c:\users\user\todolist\vendor\tymon\jwt-auth\src\providers\abstractserviceprovider.php on line 288 in file c:\users\user\todolist\vendor\tymon\jwt-auth\src\blacklist.php on line 54"
more than two days , while trying to use Tymon/Jwt in my Laravel 6.0 , i have changed laravel version back to 5.8 , finally i got the token in Postman :)
Hi, I'm using "tymon/jwt-auth": "^1.0.0-rc.5"
,but still get 401 Unauthorized
, I can get the token , but use it to Bearer will get the 401 , is there anyone can help?
@I2C-RoyYou that is not a bug with this issue - can you post on stackoverflow?
Hi there, I'm using "composer require tymon/jwt-auth 1.0.0-rc.5" . It's working for me
Version 1.0.0-rc.5 worked for me too.
Please support Laravel v6.