Open Shizzen83 opened 4 years ago
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Regression about JWTs without TTL
Because of PHP property type-hinting on
Tymon\JWTAuth\Builder::$ttl
, JWTs without TTL do not work longer. It's a cinch to fix by replacingint
with?int
in order to allownull
.Your environment
Steps to reproduce
Set
ttl
config variable tonull
and removeClaims\Expiration::NAME
fromrequired_claims
part. Then try to generate a JWTExpected behaviour
A JWT should be generated without TTL/expiration
Actual behaviour
TypeError: Typed property Tymon/JWTAuth/Builder::$ttl must be int, null used
@tymondesigns Would it be possible to hotfix this in 2.x branch please?