Unable to upgrade to Laravel 9 due to this package

ltsochev-dev commented 2 years ago

Subject of the issue

I have a very recent installation of Laravel 8.x. The only 3rd party library that I have is this one and it fails the upgrade for me because for some reason this library requires bunch of Illuminate packages that are linked to older Laravel versions.

Your environment

Q	A
Bug?	yes
New Feature?	no
Framework	Laravel
Framework version	9.0
Package version	dev-develop
PHP version	8.1

Steps to reproduce

Install Laravel 8
composer require -w tymon/jwt-auth --ignore-platform-reqs
change the composer.json laravel/framework to version "^9.0"
run composer install and you'll get an upgrade error

Expected behaviour

I was hoping there would be no issue upgrading this library.

Actual behaviour

The updates fails with the following message. Maybe you shouldn't hardcode into specific Illuminate\Support versions but rather any that would fit the requirements?

- Only one of these can be installed: illuminate/support[v4.0.0-BETA2, ..., 4.2.x-dev, v5.0.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev], laravel/framework[v9.0.0-beta.1, ..., 9.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it.
    - Root composer.json requires laravel/framework ^9.0 -> satisfiable by laravel/framework[v9.0.0-beta.1, ..., 9.x-dev].
    - Root composer.json requires tymon/jwt-auth * -> satisfiable by tymon/jwt-auth[dev-dependabot/composer/yoast/phpunit-polyfills-tw-1.0.0, dev-dependabot/add-v2-config-file, dev-master, dev-develop, 0.1.0, ..., 0.5.12, 1.0.0-alpha1, ..., 1.0.x-dev (alias of dev-develop), 2.0.x-dev].

P.S: I could do a Pull Request with updated composer.json that includes Laravel 9 but I think that's maintainer's job. Drop me a comment if you prefer a PR.

rujaun commented 2 years ago

I have made a pull request for this exact problem: https://github.com/tymondesigns/jwt-auth/pull/2166

ltsochev-dev commented 2 years ago

Sweet, lets hope it gets accepted.

scajal commented 2 years ago

The package looks unmaintained, it likely won't be merged

ltsochev-dev commented 2 years ago

The package looks unmaintained, it likely won't be merged

Well last commit is on 2nd of February this year. I don't think it's abandoned. Besides Laravel released like yesterday. It's ok.

scajal commented 2 years ago

The package looks unmaintained, it likely won't be merged

Well last commit is on 2nd of February this year. I don't think it's abandoned. Besides Laravel released like yesterday. It's ok.

2nd of February 2021:

tomfordrumm commented 2 years ago

I just forked this one repo and changed composer that it fits Laravel 9 now. You can use my fork while this package will be updated.

composer require tomfordrumm/jwt-auth:dev-develop

mfn commented 2 years ago

There's a community maintained fork at https://github.com/PHP-Open-Source-Saver/jwt-auth which already supports L9 , it requires minimal changes to switch over.

ltsochev-dev commented 2 years ago

There's a community maintained fork at https://github.com/PHP-Open-Source-Saver/jwt-auth which already supports L9 , it requires minimal changes to switch over.

Thanks for the information

kovalovme commented 2 years ago

@tymondesigns please approve

matheuscamarques commented 2 years ago

aprove please

zishang520 commented 2 years ago

19 days are gone.

mohamed-foly commented 2 years ago

I forked and applied the required updates composer require mohamed-foly/jwt-auth:dev-laravel-9 https://packagist.org/packages/mohamed-foly/jwt-auth#dev-laravel-9

nausixkiz commented 2 years ago

There's a community maintained fork at https://github.com/PHP-Open-Source-Saver/jwt-auth which already supports L9 , it requires minimal changes to switch over.

Thank you

tymondesigns / jwt-auth