search

tympanix / Electorrent

A remote control client for µTorrent, qBittorrent, rTorrent, Transmission, Synology & Deluge
GNU General Public License v3.0
1.03k stars 84 forks source link

No option to delete data when torrent is removed #74

Closed austinfox closed 7 years ago

austinfox commented 7 years ago

Client:

Client Version: 3.7 Operating System: MacOS Sierra 10.12.6 Application Version: 2.1.8 Description: Removing a torrent does not remove the corresponding file/folder associated with the torrent. In the rTorrent webui, there is an option to 'remove and delete data'. Electorrent should expose this option or remove the data by default (assumes user has dealt with data - downloaded via ftp etc...)

austinfox commented 7 years ago

Based on this function from ruTorrent: https://github.com/Novik/ruTorrent/blob/master/plugins/erasedata/init.js#L41

It appears the only addition needed to add this functionality is a call to 'd.delete_tied' from the xmlrpc api before making the call to 'd.erase'. I'm not exactly sure what the first call to 'set_custom5' is doing, but I don't think this is necessary. See https://github.com/mdevaev/emonoda/wiki/rTorrent-XMLRPC-Reference for reference

tympanix commented 7 years ago

Thank you. I have been searching on documentation on how to achieve this myself. Feature will be added in the upcoming release.

tympanix commented 7 years ago

For future references the set_custom5 property is necessary for the deletion of files to work. Somehow, behind the scenes, rTorrent checks for this property upon deletion. A value of 1 means normal deletion while 2 means force deletion.

austinfox commented 7 years ago

Amazing turnaround! Thanks for handling this - I would have eventually submitted a PR but it looks like it was easy for you as you already know the code base 😜. Does XMLRPC have better documentation somewhere? I had no idea what set_custom5 did, glad you figured it out though.

tympanix commented 7 years ago

No in general there is not much documentation on rTorrent, which is a real shame. The links you provided are the ones I use myself. ruTorrent by Novik also has, according to me, a rather difficult code base to read. Ultimately I would also like the set ratio group and set channel option from rTorrent - but without documentation I am lost. If you come across any hints let me know.

austinfox commented 7 years ago

I'll add it to my to-dos. I'm sure I can find it if I get some time. Basically, the way I found the 'Remove and Delete Data' option was to go to the ruTorrent code base, search for that text and find the corresponding code that is called when that link is clicked. I bet I can do the same with the ratio/channel options