search

tynany / frr_exporter

Prometheus exporter for Free Range Routing
MIT License
100 stars 34 forks source link

Adding Peer Identity to labels #97

Closed joseph-theiss closed 1 year ago

joseph-theiss commented 1 year ago

Current:

frr_bgp_peer_state{afi="ipv4", ..., vrf="default"}

Suggested:

frr_bgp_peer_state{afi="ipv4", ..., vrf="default", identity="SomeCoolNewNode"}

Having and identity field will help identifying dynamic components in a DMVPN with hundreds of nodes on a grafana dashboard.

And example frr command which links BGP IP, NMBA, Claimed NMBA, and Identity show ip nhrp cache

tynany commented 1 year ago

Sorry for the delay in getting to this. Can you please provide a specific example of the feature you're requesting (i.e. where does "SomeCoolNewNode" come from?).

For example: "From the output of show ip nhrp cache, please use text $insertYourCriteria as the identity label."

4xoc commented 1 year ago

FRR already gets fqdns through bgp capabilities (at least when the peer supports it too). This information is already easily available within vtysh. In my mind that would the the logical source for such label (maybe actually called hostname instead of identity). Happy to do this code change too.

tynany commented 1 year ago

This feature is now available in release v1.2.0 thanks to @4xoc.