search

tynor88 / Topshelf.SimpleInjector

Put your apps on the Topshelf, with the power of SimpleInjector & Quartz.NET!
MIT License
13 stars 14 forks source link

Support for Quartz.NET 3.x / async? #18

Open andreasnilsen opened 8 years ago

andreasnilsen commented 8 years ago

Will this library be updated for Quartz.NET 3.x and the rewrite to async support for IJob, or should I roll my own decorators and DI setup if I wish to use Quartz.NET 3.x?

tynor88 commented 8 years ago

Hi @andreasnilsen

A PR is very welcome, as I'm quiete busy in my personal life at the moment.

andreasnilsen commented 8 years ago

@tynor88 I dabbled a bit with it locally, but I was very unsure how to handle that ISchedulerFactory.GetScheduler is now async/returns a Task... should I force it into being synchronous by calling something like .Result? I guess it is safe to assume that Topshelf will run as a console app or windows service, but calling .Result on async code in an UI application can potentially deadlock it.

Anyway, would it be ok to update dependencies on all frameworks to the newest in such a pull request, or would you prefer to keep them at a minimum version?

tynor88 commented 8 years ago

Yea, that should be fine. It's safe to assume that Topshelf will run inside a Console application (or Windows Service).

Updating the nuget packages should be fine. But please keep the .NET framework at the lowest possible version.