search

tynor88 / docker-rclone

Docker for Rclone - a command line program to sync files and directories to and from various cloud services.
GNU General Public License v3.0
32 stars 32 forks source link

Push new build to dockerhub #5

Closed janajri closed 6 years ago

janajri commented 6 years ago

Thanks for this docker image, really useful but would you mind pushing latest build? I'd like to use latest features in 1.39

efrecon commented 6 years ago

Still no build? Support for box is missing from the current build (1.35 of rclone, which is, at the time of writing 1.40). Can I help in any way?

efrecon commented 6 years ago

I have sent you a PR that entirely automates the process of creating tags for every known version of rclone. Resulting images are as exemplified here.

tynor88 commented 6 years ago

Hi @efrecon thanks for the PR. It's a great idea.

I will merge it today.

tynor88 commented 6 years ago

Merged. 1.40 is up @janajri and @efrecon https://hub.docker.com/r/tynor88/rclone/tags/

Thanks for the PR!

Skaronator commented 6 years ago

The latest tag didn't get a update?

efrecon commented 6 years ago

No, latest doesn't appear as an official tag at the rclone project. I guess latest should be based on "current", which is at another URL, the hooks builds needs to manually modified. An alternative would be to have two different Dockerfiles, both used at the hub: one for building all existing releases in one go, another one for building "current" (which would translate to latest).

Skaronator commented 6 years ago

Could you not use the highest number as latest tag? Or select the first element from the github json file?

tynor88 commented 6 years ago

@Skaronator 👍 good idea, sounds like an easy fix.

I can also ask the maintainer of rclone, if he can add a commit-hook to his repo, to force a new build of this docker image.

efrecon commented 6 years ago

@Skaronator @tynor88 I am working on a fix using the top release number of the list and considering it as latest. Hope to send a new PR for this soon.

Skaronator commented 6 years ago

Cool, thanks!

efrecon commented 6 years ago

Request is at #8. Hope you can merge it. It works as advertised on my version of this at the hub.

tynor88 commented 6 years ago

@Skaronator @efrecon merged. Thanks for the PR 👍