Typos & Properties - Githubissues

tyoeer / Chaoshead

A level editor, scripting interface, campaign editor, and reverse engineering tool for Levelhead

Apache License 2.0

4 stars 1 forks source link

Typos & Properties #4

Closed Adrthegamedev closed 2 years ago

Adrthegamedev commented 2 years ago

Fixed typos:

"Slipy Goo Background" -> "Slippy Goo Background" (levelElements.tsv)
"Falltrough Ledge" -> "Fallthrough Ledge" (levelElements.tsv)
"Falltrough Wood" -> "Fallthrough Wood" (levelElements.tsv)
"Falltrough Spookstone" -> "Fallthrough Spookstone" (levelElements.tsv)
"Falltrough Kronkrete" -> "Fallthrough Kronkrete" (levelElements.tsv)
"cconflicting" -> "conflicting" (properties.tsv)

Changes:

added the "Color" property to bumpers (property 47)
added "Muted" to the clock switch (property 76)
added Movement Type, Direction, and Rotation Speed properties to jabbers (properties 30, 40, and 58)
changed bounds of the "Fire Delay" property to be 0-2 (property 25) ((although haven't tested if this commit fixed this, but there's a bug where 0.5 is displaying as 0 in fire delay))

Adrthegamedev commented 2 years ago

also, i noticed a lot of duplicated property names, maybe you should go do something about that?

tyoeer commented 2 years ago

@Adrthegamedev Thanks! Nice work finding those! I'm curious though, where did you find Chaoshead? I thought I knew everyone who was using it, with how niche it is.

The data .tsv's are also meant to mirror the online spreadsheet (I should probably write that down somewhere), but I'll mirror the changes there.

Property names should reflect be as much the same as how Levelhead displays them, Levelhead has 7 different properties called "Speed", so CH tries to copy that as much as possible. Only in case where it would lead to conflicting API names (when a level element has multiple properties of the same name) does it need to change, which is why some Speeds are renamed "Rotation Speed".

Adrthegamedev commented 2 years ago

I'm curious though, where did you find Chaoshead?

Found it through a comment in the baba is you discord while some people (specifically Saltbearer and Whee23) were talking about levelhead. Coincidentally, i was also getting into levelhead at the same time, and i found a few properties missing, so i just wanted to help out :)

The data .tsv's are also meant to mirror the online spreadsheet (I should probably write that down somewhere), but I'll mirror the changes there.

Yeah, I thought that was the case, given how the spreadsheet seemed to be based on the data.

Only in case where it would lead to conflicting API names (when a level element has multiple properties of the same name) does it need to change

Ooooohhhhh, makes sense. I thought that any of the names being duplicates would conflict, but this makes more sense 👍