typaint / probability-and-inference-portfolio-painter-ty

DS-5620 Probability and Inference
0 stars 0 forks source link

06-order-statistics #6

Closed jamiegjoseph closed 3 years ago

jamiegjoseph commented 3 years ago

No submission yet.

typaint commented 3 years ago

Deliverable 6 has now been submitted. Thanks! @jamiegjoseph

jamiegjoseph commented 3 years ago

Great job so far! Your last graphs (1.10) look a little off because you don't have a large enough range of x values. Recall for a standard normal distribution that while a lot of values will fall between -1 and 1, there will be a lot of instances where X is less than -1 or greater than 1 as well (so the minimum, for instance, will probably be less than -1 in a lot of cases). I might try going between -4 and 4 (or something along those lines), and you'll see graphs that show you the distributions better.

typaint commented 3 years ago

I have updated the graphs for question 1.10. Thanks! @jamiegjoseph

jamiegjoseph commented 3 years ago

For some reason, the graphs in 1.10 still look the same-did you knit the new code to html/post the newest version?

typaint commented 3 years ago

I deleted the old files and pushed the new one. This one should work hopefully. Thanks!

jamiegjoseph commented 3 years ago

Hi Ty, the graphs are still showing up the same for me; the xlim is restricted to -1.5 and 1.5, which is too small a range since the minimum will hover somewhere around -3 in most simulations that you run. I'm happy to talk via Slack or Zoom if something is going wrong with the submission or if you have any questions!

typaint commented 3 years ago

I have updated the graphs with the limits at -4,4. I had them at -1.5,1.5 because my graphs do not extend past there. Would my graphs be incorrect then?

jamiegjoseph commented 3 years ago

Ah I see the problem! Sorry about the confusion on my end. You did update the xlim, but you only run your order functions on x values ranging from -1 to 1 (your xvalues variable is set up that way). Making that variable go from -4 to 4 or so should probably fix your issue!

typaint commented 3 years ago

I figured I did something wrong with the graphs. I have updated the order function parameters. Hopefully this works!

jamiegjoseph commented 3 years ago

PASS Excellent job!