Closed sheikalthaf closed 2 months ago
Hello @sheikalthaf this pull request is covering too many topics to be reviewed as a single one. I also encourage you to communicate with the team with issues before working on such a big work. Because for example, there is no plan to support SSR so far.
Standalone might be good as a lone topic, you also need to rebase your branch as it includes an unwanted commit here.
Hello @sheikalthaf this pull request is covering too many topics to be reviewed as a single one. I also encourage you to communicate with the team with issues before working on such a big work. Because for example, there is no plan to support SSR so far.
Thanks for your feedback. I just wanted to convert the app to standalone, but I don't know that SSR is removed. I'll remove the SSR from my PR. Also i have added multiple commits for easy review.
Thanks for the consideration of review with separate commits but it won't help in fact: by focusing on separate reviews, I would not get the global vision of the project and might not know if all Components moved to Standalone.
Thanks for the contribution!
@geromegrignon ok i got your point, maybe i can create multiple small PRs for easy review.
@sheikalthaf with only the standalone focus, this PR is perfect!
Closing this PR, and creating multiple PRs for the same