content: add http category and HttpClientModule checklist item

typebytes / angular-checklist

🔥 Curated list of common mistakes made when developing Angular applications

https://angular-checklist.dev

MIT License

316 stars 66 forks source link

content: add http category and HttpClientModule checklist item #19

Closed FUNExtreme closed 5 years ago

FUNExtreme commented 5 years ago

As promised. This pull request will create a new category 'HTTP' containing a checklist item on why not to reimport HttpClientModule. As per the contributing guidelines I've tried to keep it as short and concise as possible.

I'll write a more in-depth blogpost about this later for those looking for more information.

KwintenP commented 5 years ago

LGTM. @d3lm any remarks?

d3lm commented 5 years ago

Overall it looks good to me. Great job and thanks for the PR @FUNExtreme!

I only left a some minor comments.

FUNExtreme commented 5 years ago

Great feedback, all resolved now!