search

typebytes / angular-checklist

🔥 Curated list of common mistakes made when developing Angular applications
https://angular-checklist.dev
MIT License
316 stars 66 forks source link

content(components): only manipulate the dom via the renderer #25

Closed billyjov closed 5 years ago

billyjov commented 5 years ago

Add new checklist item to components, only manipulate the dom via renderer

d3lm commented 5 years ago

Oh and something I forgot to mention. The commit scope is not correct. Please use components (the category) for the scope. You can also get rid of the commit body (which is optional) because the commit message is pretty self explanatory.

Thanks @billyjov!

billyjov commented 5 years ago

@d3lm regarding the commit message, can we squash all commits and rename single commit after reviews? I never did it, but know that it's possible

KwintenP commented 5 years ago

Thanks for your contribution @billyjov! Very good item to add 🎉

KwintenP commented 5 years ago

LGTM.

I think this is ready to merge. Could you please also squash your commits so there is only a single commit for this entire change? Thanks!

billyjov commented 5 years ago

@KwintenP done!