search

typebytes / angular-checklist

🔥 Curated list of common mistakes made when developing Angular applications
https://angular-checklist.dev
MIT License
316 stars 66 forks source link

Translation Contribution #45

Open MSakamaki opened 5 years ago

MSakamaki commented 5 years ago

Motivation for behavior

Users want to be able to display in a suitable language by selecting their native language.

Tasks

To-Do

Other

If continue to AoT build, url must be added one path. since I do not know firebase, I do not understand the influence. maybe this will be unnecessary with the transloco.

d3lm commented 5 years ago

Thanks for opening this issue! I do agree that translations would be really cool and very useful. I'll have a look and think about this and how we can integrate this into the checklist.

MSakamaki commented 5 years ago

I tried to added feature a basic translation system. I would be glad to point out a possible problem. https://github.com/MSakamaki/angular-checklist/tree/feature-i18n

I now will start translating content. If translation is completed, PR will be issued.

There are also samples that work via my firebase, so please take a look. https://angular-checklist-dev-b2588.firebaseapp.com/ja/projects

d3lm commented 5 years ago

Awesome! Can you make sure to not send a gigantic PR? I would rather prefer smaller PR's as they are easier to review. Let's keep them small and concise so that we can potentially iterate over requested changes. So my suggestion would be to send a PR that

  1. implements i18n
  2. individual translations

Does that sound reasonable to you @MSakamaki?

Can't wait for this PR! This will be a super awesome contribution.

MSakamaki commented 5 years ago

@d3lm OK ! I will split it into a implements PR. It's easy to get rid of the translation, so we will send PR during today.

I have translated almost everything and confirmed that there is no lack of functionality.

There is one problem, and it is difficult to translate words (words embedded in typescript such as modal buttons) that are not in the template in the application.

I look forward to using this at https://angular-checklist.io/ !

MSakamaki commented 5 years ago

@d3lm If the split is wrong, I would be glad if you pointed out. I'm can probably divide it into smaller PR.

  1. The ability to generate content.json in multiple languages
  2. Put i18n tag in html
  3. Insert ngx-i18nsupport
  4. i18n build mechanism and firabase settings
  5. Translation of application xlf
  6. Translation of content markdown

If I am wrong, I withdraw the present PR and immediately start working!

d3lm commented 5 years ago

Hey @MSakamaki, it will take a couple if days for me to review the PR. The smaller and self-contained and atomic you can make the PRs the better. This will help me more quickly review your work. So if you want you can break up the PR into small pieces that work on their own without needing anything from other PRs. This is important. Because otherwise we'd merge code that doesn't really work. Does that make sense?

Thanks again for this awesome contribution 👏👏👏

MSakamaki commented 5 years ago

@d3lm I am also very grateful for the advice, as this is my first big pull request.

I divide it into the small PR raised above. (at the top of issues, I prepare a checklist to show progress)

Thanks!

d3lm commented 5 years ago

Thanks so much for your work @MSakamaki. Really appreciate your energy you're putting into this. This will have a huge impact and I really love it that we are making the checklist more accessible to people around the world from different countries. Really really cool.

MSakamaki commented 4 years ago

The above steps will be updated to match the transloco.

d3lm commented 4 years ago

Very very nice! Thank you so much for pushing this forward. I really can't wait to have translations available. This will make it very accessible to many people around the globe ❤️❤️❤️