Closed eduardoRoth closed 2 years ago
Hey @eduardoRoth, I encourage you to make more specific and distinct PRs: it will help the maintainers review them.
Hey @eduardoRoth, I encourage you to make more specific and distinct PRs: it will help the maintainers review them.
Sure @geromegrignon , I'll modify the PR to include everything that I modified. Thanks 😄
I mean you should make separate PRs: some content might be biased and would require discussion (or might be refused). It would delay the whole PR.
here is a recommendation from one of the maintainers:
I would try to keep PR's as small as possible. The sooner you submit something, the sooner we can provide feedback. :)
I mean you should make separate PRs: some content might be biased and would require discussion (or might be refused). It would delay the whole PR.
here is a recommendation from one of the maintainers:
I would try to keep PR's as small as possible. The sooner you submit something, the sooner we can provide feedback. :)
Ok, I'll make the change 😄
In this PR I made the following changes:
never mutate objects and embrace immutability
, a duplicatedare
Following PRs will be one per modification.