typebytes / angular-checklist

🔥 Curated list of common mistakes made when developing Angular applications
https://angular-checklist.dev
MIT License
316 stars 66 forks source link

PR: Update best practices #87

Closed eduardoRoth closed 2 years ago

eduardoRoth commented 2 years ago

In this PR I made the following changes:

Following PRs will be one per modification.

geromegrignon commented 2 years ago

Hey @eduardoRoth, I encourage you to make more specific and distinct PRs: it will help the maintainers review them.

eduardoRoth commented 2 years ago

Hey @eduardoRoth, I encourage you to make more specific and distinct PRs: it will help the maintainers review them.

Sure @geromegrignon , I'll modify the PR to include everything that I modified. Thanks 😄

geromegrignon commented 2 years ago

I mean you should make separate PRs: some content might be biased and would require discussion (or might be refused). It would delay the whole PR.

here is a recommendation from one of the maintainers:

I would try to keep PR's as small as possible. The sooner you submit something, the sooner we can provide feedback. :)

eduardoRoth commented 2 years ago

I mean you should make separate PRs: some content might be biased and would require discussion (or might be refused). It would delay the whole PR.

here is a recommendation from one of the maintainers:

I would try to keep PR's as small as possible. The sooner you submit something, the sooner we can provide feedback. :)

Ok, I'll make the change 😄