Closed sheikalthaf closed 6 months ago
After upgrading to latest version of highlight.js code highlight is improved.
Before:
After:
Also added some border radius to avoid sharp edges
OMG this is awesome <3 Thanks so much for this PR! 🙏
@sheikalthaf Hey there! Sorry for the silence for so long. I'd love to get this over the finish line. Would you want to upgrade to the latest v14 as well?
@d3lm updated the PR. Please review the changes
Thanks so much!
@santoshyadavdev Can you review the changes as well?
@santoshyadavdev @d3lm any updates on this PR?
@d3lm @santoshyadavdev any plan to merge this PR?
Hi @d3lm can we get this merge.
Yea, I ll have a look again at this PR this week.
@sheikalthaf When I run the app I am seeing this error now:
The icons in the footer don't work anymore.
@sheikalthaf Hmm, but the icons didn't flicker before 🤔
Also there seems to be a workaround https://github.com/FortAwesome/angular-fontawesome/issues/48#issuecomment-432543956.
Also there seems to be a workaround FortAwesome/angular-fontawesome#48 (comment).
@d3lm I tried the workaround and it works. I just can't push commits on the PR to fix it:
.svg-inline--fa {
vertical-align: -0.125em;
}
fa-icon svg {
display: inline-block;
font-size: inherit;
height: 1em;
}
fa-icon .fa-2x{
font-size: 2em;
}
Oh thanks @geromegrignon. I can try to push this this evening. We may wanna merge this one then, and then update to the latest again? 😅
yes indeed.
@d3lm @geromegrignon sorry for the late response, I'll try to push the changes now
@d3lm pushed the changes, thanks for the code @geromegrignon
@d3lm any update on this PR?
Hi @sheikalthaf, if you are still around, I'm now reviewing the PR as I just joined the team as a maintainer to revive the project.
In this PR I have update the list of items
closes #96 #99