typebytes / angular-checklist

🔥 Curated list of common mistakes made when developing Angular applications
https://angular-checklist.dev
MIT License
316 stars 66 forks source link

feat: update to Angular v14 #98

Closed sheikalthaf closed 6 months ago

sheikalthaf commented 2 years ago

In this PR I have update the list of items

closes #96 #99

sheikalthaf commented 2 years ago

After upgrading to latest version of highlight.js code highlight is improved.

Before:

image

After:

image

Also added some border radius to avoid sharp edges

d3lm commented 2 years ago

OMG this is awesome <3 Thanks so much for this PR! 🙏

d3lm commented 2 years ago

@sheikalthaf Hey there! Sorry for the silence for so long. I'd love to get this over the finish line. Would you want to upgrade to the latest v14 as well?

sheikalthaf commented 2 years ago

@d3lm updated the PR. Please review the changes

d3lm commented 2 years ago

Thanks so much!

d3lm commented 2 years ago

@santoshyadavdev Can you review the changes as well?

sheikalthaf commented 2 years ago

@santoshyadavdev @d3lm any updates on this PR?

sheikalthaf commented 2 years ago

@d3lm @santoshyadavdev any plan to merge this PR?

santoshyadavdev commented 2 years ago

Hi @d3lm can we get this merge.

d3lm commented 2 years ago

Yea, I ll have a look again at this PR this week.

d3lm commented 1 year ago

@sheikalthaf When I run the app I am seeing this error now:

image

The icons in the footer don't work anymore.

sheikalthaf commented 1 year ago

@d3lm Yes, this happens after I moved the fontawesome library icons addition to outside SharedModule constructor (The change has been made after this comment. Yes icons flickers on ssr. There is no official work around it seems link

d3lm commented 1 year ago

@sheikalthaf Hmm, but the icons didn't flicker before 🤔

d3lm commented 1 year ago

Also there seems to be a workaround https://github.com/FortAwesome/angular-fontawesome/issues/48#issuecomment-432543956.

geromegrignon commented 1 year ago

Also there seems to be a workaround FortAwesome/angular-fontawesome#48 (comment).

@d3lm I tried the workaround and it works. I just can't push commits on the PR to fix it:

.svg-inline--fa {
  vertical-align: -0.125em;
}

fa-icon svg {
  display: inline-block;
  font-size: inherit;
  height: 1em;
}

fa-icon .fa-2x{
  font-size: 2em;
}
d3lm commented 1 year ago

Oh thanks @geromegrignon. I can try to push this this evening. We may wanna merge this one then, and then update to the latest again? 😅

geromegrignon commented 1 year ago

yes indeed.

sheikalthaf commented 1 year ago

@d3lm @geromegrignon sorry for the late response, I'll try to push the changes now

sheikalthaf commented 1 year ago

@d3lm pushed the changes, thanks for the code @geromegrignon

sheikalthaf commented 1 year ago

@d3lm any update on this PR?

geromegrignon commented 6 months ago

Hi @sheikalthaf, if you are still around, I'm now reviewing the PR as I just joined the team as a maintainer to revive the project.