search

typed-ember / ember-cli-typescript

Use TypeScript in your Ember.js apps!
https://docs.ember-cli-typescript.com
MIT License
363 stars 99 forks source link

Including ember-cli-typescript into an app with ember-cli-babel@7.7+ emits warnings #707

Closed rwjblue closed 5 years ago

rwjblue commented 5 years ago

What are instructions we can follow to reproduce the issue?

ember new test-ts-warning
cd test-ts-warning
ember install ember-cli-typescript
ember build

Now about that bug. What did you expect to see?

No console warnings.

What happened instead?

The following warnings are emitted:

WARNING: test-ts-warning has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: test-ts-warning has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
rwjblue commented 5 years ago

Will be fixed by https://github.com/typed-ember/ember-cli-typescript/pull/640

bartocc commented 5 years ago

640 has been superseeded by #730

chriskrycho commented 5 years ago

Thanks for flagging it up, @bartocc! This is indeed resolved by #730, now closed.

lolmaus commented 5 years ago

Hi! I'm using ember-cli-typescript@2.0.2 which seems to include this PR: https://github.com/typed-ember/ember-cli-typescript/commits/master?after=03134c31ab25ab7ffef60b6fee1b32cc9f1fadc1+104

But I'm still seeing this in the terminal: 

WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.
WARNING: wbc has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.

How to get rid of those?

I've checked yarn.lock, and the only addons using class-properties are ember-cli-babel and ember-cli-typescript.

dfreeman commented 5 years ago

@lolmaus v2.0.2 doesn't include a fix for this yet: https://github.com/typed-ember/ember-cli-typescript/commits/v2.0.2

Instead we opted to drop support for ember-cli-babel < 7.7.3 completely, which is a breaking change that's queued up with a few other things for a 3.0 release, which will hopefully be coming soon! We just have a few last things to wrap up in the meantime.

lolmaus commented 5 years ago

@dfreeman Thx for the clarification! 🙇

CC @simonihmig @nickschot @andreasschacht