typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
110 stars 51 forks source link

Don't duplicate diagnostic code information #528

Closed dfreeman closed 1 year ago

dfreeman commented 1 year ago

Now that we're correctly tracking diagnostic code in its own field, also embedding it in source is redundant and can result in the editor showing a diagnostic's code twice, e.g. glint:ts(2345)(2345).

This change simplifies the source to just glint (dropping the ts: part, since we don't invent our own error codes apart from TypeScript's), allowing the editor to construct the tag as e.g. glint(2345) itself.