typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
110 stars 51 forks source link

Glint does resolve `extends` in `tsconfig.json` from external packages #549

Open cafreeman opened 1 year ago

cafreeman commented 1 year ago

When extending a tsconfig that includes a glint configuration , glint doesn't follow the extends and, therefore, does not recognize that any config is present.

I've created a reproduction here: https://github.com/cafreeman/glint-extends-bug-repro

chriskrycho commented 1 year ago

Clarification—I believe this works correctly for local paths, based on this code:

https://github.com/typed-ember/glint/blob/3b0d3ab78765c2b39e25e09788597609740cacad/packages/core/src/config/loader.ts#L79

If I'm understanding correctly, both from that repro and from our discussion in chat, the issue is specifically that it does not follow an extends which points to a different package, right? Thus meaning that if we, say, set up a @tsconfig/ember-with-glint, it wouldn't be usable.

cafreeman commented 1 year ago

Good catch. Yes, you're correct. It only seems to come up when actually extends a tsconfig from another package.

NullVoxPopuli commented 10 months ago

I think this is resolved, as all projects I'm aware of that use Glint extend from @tsconfig/ember, or some other in-monorepo custom config, such as @my-place-of-work/tsconfig.