typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
109 stars 51 forks source link

Syntax error in tsconfig.json causes out-of-memory error #614

Open NullVoxPopuli opened 1 year ago

NullVoxPopuli commented 1 year ago

This was a goofy discovery :sweat_smile:

I kept getting OOM exceptions from node when trying to run glint via pnpm lint:types (package.json "lint:types": "glint"), so I kept increasing the amount of memory used -- I finally ended up with

NODE_OPTIONS="--max-old-space-size=12000" pnpm lint:types # or just pnpm glint directly

And I forgot the process was running cause prior attempts at increase the node ram were getting slower and slower -- this ultimately took 36 minutes before the OOM error occurred.

I was ultimately trying to debug performance, and eventually ran:

pnpm tsc --generateTrace trace.txt --traceResolution

(or something to that effect) And tsc provided me the error right away: image

So, from my perspective, it looks like glint is trying to do something and continuing to do something even thought tsc should error? idk.

chriskrycho commented 1 year ago

Thanks for the report; this seems like a case where Glint should be bailing and is not! Do you happen to have a minimal reproduction of this?


Aside: In the future, please copy and paste the output rather than sharing a screenshot. Screenshots are fundamentally not accessible to lots of folks who may need to interact with the repo. I happen to be well-sighted, but not everyone is!

NullVoxPopuli commented 1 year ago

Screenshots are fundamentally not accessible to lots of folks who may need to interact with the repo

yes, I did not have the text available at the time. <3

NullVoxPopuli commented 1 year ago

Do you happen to have a minimal reproduction of this?

I do not :(