search

typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
109 stars 51 forks source link

Support import paths with .gts extensions #620

Closed lukemelia closed 1 year ago

lukemelia commented 1 year ago

Note that using imports with extensions requires TypeScript 5 and enabling the setting to support importing files with typescript extensions ("allowImportingTsExtensions").

Fixes #618

lukemelia commented 1 year ago

Updates made! Thanks for the feedback @NullVoxPopuli

dfreeman commented 1 year ago

I've opened a PR with an alternative approach to this problem in #621

@lukemelia I want to apologize for the miscommunication on this and the time/effort it's cost you—it's 100% my fault. I'd had a separate conversation in Discord about what would need to happen to fix this, and then on #618 I got sidetracked by some of the meta-questions being asked and didn't focus properly on the fix you were suggesting there to realize that you hadn't been a part of or seen that original conversation.

Thank you very much for your work on this, and I'm sorry for pointing you in the wrong direction!

lukemelia commented 1 year ago

No worries, @dfreeman. Thanks for resetting us onto the right path.