typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
109 stars 51 forks source link

Update `vscode-uri` and match their docs #629

Closed NullVoxPopuli closed 11 months ago

NullVoxPopuli commented 12 months ago

On projects using 1.2.0 of Glint, they'll run in to this:

file:///home/nvp/Development/NullVoxPopuli/polaris-starter-2/node_modules/.pnpm/@glint+core@1.2.0_typescript@5.2.2/node_modules/@glint/core/lib/language-server/util/index.js:3
import VSCodeURI from 'vscode-uri';
       ^^^^^^^^^
SyntaxError: The requested module 'vscode-uri' does not provide an export named 'default'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

Which makes sense since @glint/core didn't declare a dep on vscode-uri.

Locally, when testing, I was using the 1.2.0 version of the language server, / vscode extension, so I don't know if that'll need to be published :shrug:

dfreeman commented 11 months ago

Thank you! I'll do a bugfix release shortly so no one else gets bitten by this