Use `content-tag` instead of `ember-template-imports`

NullVoxPopuli commented 10 months ago

ember-template-imports @ v4 removed all the APIs that glint was relying on for working with <template>-tags

Extractions:

Allows:

folks to <pm> add ember-template-imports in their apps and not have to downgrade to v3 if they want to use Glint
better syntax handling
better incorrect syntax handling

NullVoxPopuli commented 9 months ago

I'm marking as ready for review, as I think this is about at the point, where I want to make sure I'm not doing anything crazy.

There is still a failing test: https://github.com/typed-ember/glint/actions/runs/7254626609/job/19763687113?pr=655#step:6:107 which... I have no idea how this code affects the reporting of untyped {{component}} usage, since in the "debug extension" thing, the 4 use cases all error correctly (as expected).

cc @dfreeman @wagenet @gitKrystan

Some things left for this PR tho:

[ ] push more work in to content-tag, per @ef4's comment here: https://github.com/embroider-build/content-tag/issues/39#issuecomment-1832443310
[ ] put content-tag in ember-template-lint ideally, when this PR is done, we'll see ember-template-imports removed from the lockfile entirely (tho, we'd also have to remove GlimmerX for that.... )

lifeart commented 8 months ago

I like this changes! We definitely need to push it forward and land it! Works just fine inside custom glint env https://github.com/lifeart/glimmer-next/tree/master/glint-environment-gxt

typed-ember / glint