search

typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
109 stars 51 forks source link

feat(vscode): add jsx and tsx to the list of watched extensions #699

Closed poulet42 closed 7 months ago

poulet42 commented 7 months ago

👋 I have a usecase where I'm getting types from a .tsx file, glint errors does show up but does not get updated when the tsx types changes. This PR adds .tsx (and .jsx for consistency(?)) to the list of extensions to watch.

I understand this is a rather unlikely usecase in a glint codebase but I'm trying my luck 🙏 . Another alternative would be to expose the list of extensions to watch as a setting but it's a bit more work

NullVoxPopuli commented 7 months ago

I think this should probably be configurable. While it's common for folks to mix in React with Ember, I don't want to give React special treatment, and would like to equally support extending this extension list. That way, if folks are using Ember with Vue, Svelte, etc, they have a path to do so

poulet42 commented 7 months ago

@NullVoxPopuli Thank you for your answer 🙏 I'm closing this MR in favour of a more generic "glint.watchExtensions" setting. I'll take some time to work on it