search

typed-ember / glint

TypeScript powered tooling for Glimmer templates
https://typed-ember.gitbook.io/glint
MIT License
108 stars 50 forks source link

Add template import type for uniqueId helper #723

Open vstefanovic97 opened 1 month ago

vstefanovic97 commented 1 month ago

This in combination with https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69687 should make importing uniqueId from @ember/helper work

NullVoxPopuli commented 1 month ago

Why does glint need code changes at all?

vstefanovic97 commented 1 month ago

Why does glint need code changes at all?

@NullVoxPopuli as far as I can tell the types defined in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69687/files#diff-ee310ca708dd6726cf0487230fae7935b0eecd94c32c37e022b0776a82506bb7R15 don't have any real type information and we rely on extending the interfaces here in glint

NullVoxPopuli commented 1 month ago

We may need to start a 1.x branch, because main is currently breaking, preparing for v2 / a new approach to glint

NullVoxPopuli commented 1 week ago

This'll be in the main/2.x release (which may be unstable for a while). (looks like you have lint issues though)

We can release this in 1.x if you also make this PR for here: https://github.com/typed-ember/glint/tree/v1.x

vstefanovic97 commented 5 days ago

@NullVoxPopuli I rebased it and repointed to the v1.x branch