search

typed-typings / npm-lodash

The type definition for https://github.com/lodash/lodash
MIT License
16 stars 22 forks source link

customizer type for clone[Deep]With #15

Closed osdiab closed 8 years ago

osdiab commented 8 years ago

I'm not 100% sure this is totally correct—if someone can confirm that would be great.

unional commented 8 years ago

It seems like key is string: https://github.com/lodash/lodash/blob/es/_baseClone.js#L73 Do you see the index usage? Besides that, LGTM

unional commented 8 years ago

Actually, maybe it is better to also make value optional You can see in its test it uses noop https://github.com/lodash/lodash/blob/master/test/test.js#L3100