typed-typings / npm-vinyl

Typings for vinyl
MIT License
0 stars 1 forks source link

Update project structure #4

Closed demurgos closed 8 years ago

demurgos commented 8 years ago

This PR updates the directory structure with the latest generator structure. It does not change the definitions.

Note: The generator-typings structure does not support mocha unit-tests so they were removed.

Reference: https://github.com/types/npm-vinyl/pull/2#issuecomment-254422414 https://github.com/types/npm-vinyl/pull/3

demurgos commented 8 years ago

I restored the original tests. But just to be sure, you never run the tests: you just compile them ?

(It also seems that I don't have the same tsc version as Travis, I'll check why it failed)

demurgos commented 8 years ago

Ok, the latest typings for Node require typescript 2. I'll revert the Node typings to an older version for the moment.

demurgos commented 8 years ago

It should be OK now, could you see if this is fine ?

I was a bit confused about what you meant with the tests, but if you just want to compile them, I'll be also able to add them for the version 2.0.0

felixfbecker commented 8 years ago

@demurgos Yes, the file is just compiled. Please just leave that as-is right now, converting them all to runtime tests is out of scope for this PR. That means please also leave out the dependencies on blue-tape. Upgrading to TS2 is not a problem.

demurgos commented 8 years ago

I took me some time, but I think that it should be good: the dependencies are updated (use TS2, no more blue-tape) and there was no breaking-change with the previous typings.

Thank you for your various comments.