search

typedb-osi / typedb-bio

TypeDB Bio: Biomedical Knowledge Graph
73 stars 30 forks source link

New branch #2

Closed hskaushik closed 4 years ago

hskaushik commented 4 years ago

Hi,

I have just rearranged the README file. I have also added appropriate links to Grakn website and youtube tutorials. I wanted to make sure if the following are acceptable. 1) I have mentioned Python >3.6 as a prerequisite. I haven't tested it on earlier versions of Python. Is it okay to leave this as is or do you suggest any changes? 2) I have included URL to one of Tomas's youtube tutorials where he discusses how to use Workbase. Is there a better tutorial than the one I have included?

I also noted that the example queries do not return anything. Probably I am doing something wrong (I still don't understand graql well enough)! In the next couple of days, I am planning to include some of my own examples starting with most simple to the complex graql queries exploring the full potential of grakn.

Advice and suggestions are welcome. Thanks, Kaushik

tomassabat commented 4 years ago

Hi @hskaushik! Thank you for your PR :)

Just a few things:

  1. For the non-returning queries, could you please create a new issue so we can address this issue separately?
  2. In your commit, you forgot to ignore your IDE files. Can you please go back and delete these files (those in the .idea folder) and commit again
  3. Please rename the PR to “Readme-updates”
hskaushik commented 4 years ago

Thank you Tomas, for taking the time to go through this. As you might have noted, I am new to git and still learning my way! Will do as you suggested.