typedb / bazel-distribution

Bazel rules for assembling and deploying software distributions (see @vaticle for usage example)
https://bazel.build
Apache License 2.0
154 stars 53 forks source link

Extend NPM deployment with password or token-based deployment #372

Closed flyingsilverfin closed 1 year ago

flyingsilverfin commented 1 year ago

What is the goal of this PR?

As of January 2023, the deploy_npm using npm v8.x rule appears to stop working with pre-generated auth tokens for Sonatype repositories. However, we discover that the simpler mechanism of using base64 encoded username/password does work.

Using the base64 encoded authenciation is also recommended by Sonatype, we can successfully deploy.

However, the deployment to centralised NPM repositories may still require using token-based authentication. As a result, we extend the deployment rule to support both username/password or token-based authentication.

This issue was last worked on in https://github.com/vaticle/bazel-distribution/pull/330

What are the changes implemented in this PR?

typedb-bot commented 1 year ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

Code

Architecture