Closed dmikhalin closed 1 year ago
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Trivial Change
Code
Architecture
We have rolled in the changes from https://github.com/vaticle/bazel-distribution/pull/378 into this PR, except the nodejs permissioning error fix, which should be easy enough to re-create.
Comments in that PR describe some of the upgrades and changes, especially related to stardoc.
What is the goal of this PR?
We upgrade rule sets
rules_python
andrules_pkg
, and remove unnecessary workarounds related to documentation generation withstardoc
.We also fix python packaging to allow including generated library files. Generated library files for python are automatically put into the
bazel-out/.../bin
directory and the module can't reach them. We move these files into the module directory.What are the changes implemented in this PR?
bazel-out/.../.../**/*
to**/*
.rules_python
version to 0.24.0 and replaced deprecatedpip_install()
withpip_parse()
.rules_pkg
to0.9.1
andrules_rust
tov0.26.0
.