Closed farost closed 4 months ago
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Trivial Change
Code
Architecture
Server PR for these tests: https://github.com/vaticle/typedb/pull/7104
Usage and product changes
We fix old
concept/schema-validation
behaviour tests, reformatting them to the newConceptAPI
steps declarations and changing small details in its logic to follow the new validation rules of3.0
.We also fix a number of new
concept/type
tests that expectedtransaction commits; fails;
results based on the final versions of commit time validations of the3.0
server. It is expected that every commit-time validation is now covered by BDD tests.Additionally, this PR presents new steps for
@values
,@ranges
,@card
annotations (with a separate check ofget cardinality
constraint), and other small things that were forgotten in the past.Implementation
I'd like to move
schema-validation
tests to differenttype
files as they have just the same meaning and it's hard to split operation time validations with commit time validations (schema validations in migration). Right now all the old tests are still in the old file for easier review.For more details, check out the comments in the changed files.