Closed farost closed 3 weeks ago
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Trivial Change
Code
Architecture
@dmitrii-ubskii I added more define and match tests in this PR as everything becomes connected. Please, check the newest commits!
Usage and product changes
We update all the existing
undefine
tests to use the new 3.0undefine
queries, add new steps to test new 3.0 functionality (new annotations, specific errors returned for query safety), and remove some of the excessive tests (mostly non-implemented ones) for cases already covered in concept BDDs.Additionally, we cover the missing cases for
match
queries:Implementation
Several todos are left for
match
queries that should verify that the un/re/-definitions are successful, but are not implemented in 3.0 for now. Unique kinds of these TODOs are highlighted by comments of this PR.