typedb / typedb-common

TypeDB Common Libraries and Scripts
GNU Affero General Public License v3.0
7 stars 14 forks source link

Include TypeDB runners in common library jar #139

Closed jamesreprise closed 1 year ago

jamesreprise commented 1 year ago

What is the goal of this PR?

Currently, we don't include the test directory files in the main jar produced by typedb-common. As raised by a community member, we should include this so other people can make use of this via the provided jars.

What are the changes implemented in this PR?

We've included all of the java files found under //test in the srcs argument to java_library.

We've also corrected one scary */* import and now explicitly specify what directory is being brought in.

typedb-bot commented 1 year ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

Code

Architecture

flyingsilverfin commented 1 year ago

I think the title of this PR can be improved :)