Fix TypeDB Windows Launcher UX

jamesreprise commented 1 year ago

What is the goal of this PR?

We can now launch TypeDB from any folder in Windows (provided TypeDB has been added to the user's environment). TypeDB also gets launched in a new window, which the user can freely close or quit via Ctrl+C without interruption once they are finished.

Fixes https://github.com/vaticle/typedb/issues/6780 Fixes https://github.com/vaticle/typedb/issues/6781

What are the changes implemented in this PR?

We've refactored 'typedb.bat' to use the absolute path rather than relative, allowing the command to be used from anywhere. We've added the keyword start before running the server via Java. This launches the server in a new window.

typedb-bot commented 1 year ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

[ ] This change is trivial and does not require a code or architecture review.

Code

[x] Packages, classes, and methods have a single domain of responsibility.
[x] Packages, classes, and methods are grouped into cohesive and consistent domain model.
[x] The code is canonical and the minimum required to achieve the goal.
[x] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
[x] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
[x] The code is algorithmically efficient and scalable for the whole application.

Architecture

[x] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
[x] Any required build and release automations are updated and/or implemented.
[x] Any new components follows a consistent style with respect to the pre-existing codebase.
[x] The architecture intuitively reflects the application domain, and is easy to understand.
[x] The architecture has a well-defined hierarchy of encapsulated components.
[x] The architecture is extensible and scalable.

jamesreprise commented 1 year ago

We have been sure to receive the @izmalk seal of approval as he was the original discoverer of the linked issues!

typedb / typedb-common