search

typedb / typedb-console

TypeDB Console: CLI for TypeDB and TypeDB Cluster
https://typedb.com
Mozilla Public License 2.0
7 stars 16 forks source link

Improve console architecture using multiple levels of PicoCLI #155

Open lolski opened 3 years ago

lolski commented 3 years ago

Make sure the style and terminology is consistent with TypeDB TypeDB is the reference implementation which we should adhere to.

Make the logic that parses the command terser and stricter, and with minimal boilerplate Please take a look at this Demonstrational PR on how much effort it takes to add relatively simple functionality. The parser is not strict and error prone, and it requires a lot of boilerplate. There are some nuances in how we should best approach the refactor, which we should discuss verbally.

flyingsilverfin commented 3 years ago

If we still need a way to escape an inner CLI without exiting completely, we can replace the boolean that is passed around for success with an Enum which will be more meaningful and easy to read

haikalpribadi commented 3 years ago

This issue may be overridden by this one: https://github.com/vaticle/typedb-console/issues/162