typedb / typedb-driver-nodejs

TypeDB Driver for Node.js
https://typedb.com
Apache License 2.0
32 stars 21 forks source link

JSON serialization fixes #220

Closed dmitrii-ubskii closed 1 year ago

dmitrii-ubskii commented 1 year ago

What is the goal of this PR?

We update serialization API from JSON() to more canonical toJSONRecord()* and update the BDD test steps to reflect the changes in typedb-behaviour (https://github.com/vaticle/typedb-behaviour/pull/240).

* We're avoiding toJSON() as it is reserved by JavaScript for built-in JSON serialization. Since our JSON representation is lossy, we'd like the user to be explicit in their intent.

typedb-bot commented 1 year ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

Code

Architecture