Update NodeJS driver to use unified network API & simplified Concept API

dmitrii-ubskii commented 1 year ago

What is the goal of this PR?

We upgrade Bazel Javascript rules and TypeDB protocol dependency to be compatible with https://github.com/vaticle/typedb-protocol/pull/183. In particular, we merge core and cluster connection facilities, and simplify Concept API by removing Remote interfaces and replacing some function calls (such as _Explicit()) with parameters.

What are the changes implemented in this PR?

update bazel rules to use rules_js and rules_ts instead of deprecated rules_nodejs
make cucumber behaviour tests hermetic
- integration tests are still performed via direct node invocations
merge Core and Cluster connection facilities: most things such as database management and session failover are now done uniformly
- update request builders and response parsers to be compatible with the proto-gen-ts generated gRPC definitions
- update concept API: remove .Remote types, Transitivity argument instead of _Explicit methods

typedb-bot commented 1 year ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

[ ] This change is trivial and does not require a code or architecture review.

Code

[x] Packages, classes, and methods have a single domain of responsibility.
[x] Packages, classes, and methods are grouped into cohesive and consistent domain model.
[x] The code is canonical and the minimum required to achieve the goal.
[x] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
[x] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
[x] The code is algorithmically efficient and scalable for the whole application.

Architecture

[x] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
[x] Any required build and release automations are updated and/or implemented.
[x] Any new components follows a consistent style with respect to the pre-existing codebase.
[x] The architecture intuitively reflects the application domain, and is easy to understand.
[x] The architecture has a well-defined hierarchy of encapsulated components.
[x] The architecture is extensible and scalable.

flyingsilverfin commented 1 year ago

Ah I see now that you worked to preserve core/cluster definitions separately. We can do that for now but then we have more work to merge them again?

typedb / typedb-driver-nodejs