typedb / typedb-ml

TypeDB-ML is the Machine Learning integrations library for TypeDB
https://vaticle.com
Apache License 2.0
550 stars 93 forks source link

Remove deprecated pip repositories Bazel call #165

Closed jamesreprise closed 2 years ago

jamesreprise commented 2 years ago

What is the goal of this PR?

We remove an unneccessary call of pip_repositories despite it being a deprecated function from rules_python, including in our own patched version. Additionally, this cleans up our bazel command output. See the output message below.

DEBUG: /private/var/tmp/[...]/external/rules_python/python/pip.bzl:228:10: 
DEPRECATED: the pip_repositories rule has been replaced with pip_install, please see rules_python 0.1 release notes

See this dependencies PR for more information:

What are the changes implemented in this PR?

We remove the command that loads the function as well as the call to the function.

grabl commented 2 years ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

Architecture