Move non-Grakn Dependency

typedb / typedb-ml

TypeDB-ML is the Machine Learning integrations library for TypeDB

https://vaticle.com

Apache License 2.0

550 stars 93 forks source link

Move non-Grakn Dependency #81

Closed flyingsilverfin closed 5 years ago

flyingsilverfin commented 5 years ago

What is the goal of this PR?

The current structure of dependencies/graknlabs/dependencies.bzl was breaking graql and sync-dependencies because it contained a non-graknlabs dependency.

What are the changes implemented in this PR?

Create a new package dependencies/python
move relevant rule from graknlabs/dependencies.bzl to python/dependencies.bzl
Update WORKSPACE correspondingly

flyingsilverfin commented 5 years ago

@jmsfltchr just submitting a quick patch so Graql becomes functional again! Only graknlabs dependencies can go into dependencies/graknlabs or graql gets confused!

haikalpribadi commented 5 years ago

@jmsfltchr just submitting a quick patch so Graql becomes functional again! Only graknlabs dependencies can go into dependencies/graknlabs or graql gets confused!

And even though @io_bazel_rules_python is hosted on a @graknlabs, it's not a Grakn Labs repo, because it's a fork of a different repo (in this case Bazel).

jmsfltchr commented 5 years ago

Ok all understood! I'll look out for this in future