typedb / typedb-studio

TypeDB Studio (IDE)
https://typedb.com
Mozilla Public License 2.0
191 stars 44 forks source link

Fix WindowContext not reflecting changes to window size #621

Closed jamesreprise closed 2 years ago

jamesreprise commented 2 years ago

What is the goal of this PR?

We fixed a bug in WindowContext where resizing the underlying window was not reflected when getting its values (i.e. height, width, x and y). This fixes a bug where certain actions such as mouse hovering didn't render tooltips because of windowContext reporting the incorrect height and width.

What are the changes implemented in this PR?

We've expanded WindowContext so that it includes 2 inner classes:

grabl commented 2 years ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

Architecture