grabl
commented
2 years ago PR Review Checklist
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Code
- [x] Packages, classes, and methods have a single domain of responsibility.
- [x] Packages, classes, and methods are grouped into cohesive and consistent domain model.
- [x] The code is canonical and the minimum required to achieve the goal.
- [x] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
- [x] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
- [x] The code is algorithmically efficient and scalable for the whole application.
Architecture
- [x] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
- [x] Any required build and release automations are updated and/or implemented.
- [x] Any new components follows a consistent style with respect to the pre-existing codebase.
- [x] The architecture intuitively reflects the application domain, and is easy to understand.
- [x] The architecture has a well-defined hierarchy of encapsulated components.
- [x] The architecture is extensible and scalable.
jamesreprise
What is the goal of this PR?
We provide users connecting to cluster servers the ablility to browse their file system and select cluster certificates, rather than having to type the filepath out (or copy paste it from their file system browser).
As a result of this PR, end users will an easier time selecting certificates for cluster server connections in the future. Contributors and developers have an abstracted file selector dialog interface that they may re-use throughout Studio.
What are the changes implemented in this PR?
The FileSelectorDialog object has been introduced, providing functions to Studio to present users with a dialog to select files or folders.
The CACertificateFormField in ServerDialog has been updated to provide a button for selecting the CA certificate.