Closed jamesreprise closed 1 year ago
Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.
Code
Architecture
Closing this for now as it's become stale after having been abandoned for too long. We can use this branch as a blueprint for future plans, but we know the preferences architecture has to change to support this.
What is the goal of this PR?
We've added a preference to change the theme of the graph visualiser. This has been requested so that people can print their graphs. End users are able to choose between a dark theme (as it currently exists within Studio) and a new, light theme for the graph output within the preferences dialog.
Contributors and developers should experience little difference, but now have a working example of a dropdown within the preferences dialog as well as an example of multiple preferences within a single preference group.
What are the changes implemented in this PR?
We've added a preference to change the theme of the graph visualiser. This does not affect the theming of the rest of Studio. As per the printer-friendly nature of the request, the background colour has been set to pure white (an off-white colour would still require colouring the background, wasting ink in ink-based printers).
This looks like this:
Feedback is welcome on the theme. Though there may be some increase in visibility and clarity gained by changing smaller details such as the edge and inference colouring, I believe the existing theme is ready for production.
We've introduced:
CommonPalette
intoframework/common/theme/Color
as many of the colours between the two graph themes are shared.LIGHT_GRAPH
GraphTheme
intoTheme
inframework/common/theme/Color
.DataManger
andPreferenceManager
Additional information
Closes: