typedb / typedb-studio

TypeDB Studio (IDE)
https://typedb.com
Mozilla Public License 2.0
191 stars 44 forks source link

Preferences design changes #645

Closed jamesreprise closed 1 year ago

jamesreprise commented 2 years ago

What is the goal of this PR?

We've made adjustments to the behaviour of the preferences dialog after some internal feedback. End users should notice a more pleasant UI/UX. Contributors and developers should notice little difference other than working examples of a multiline text input within a form to base future development off of.

What are the changes implemented in this PR?

Ticked items have been completed.

grabl commented 2 years ago

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

Architecture

alexjpwalker commented 1 year ago

It would be nice if we could line up the first line of the text field with the label on the left.

Currently it feels like the text in the text field is too low. Moreover, when we type subsequent lines, it feels like the spacing between lines is correct, so it's just the first line that is misaligned.

image